Added support for image copy path #559
Conversation
| public static final List<String> WEB_EXTENSIONS | ||
| = Arrays.asList("js", "css", "png", "jpg", "jpeg", "gif"); |
There was a problem hiding this comment.
Just wondering, isn't possible to use ImageIO::read? This should return null if the provided file cannot be read as an image. Or maybe there are some alternatives to check the file's contentType.
There was a problem hiding this comment.
I'm currently thinking of a way to support ONLY the Magento supported types. There's a lot more image types I missed which @DmitryFurs has described. So I'll check if the ImageIO types match the supported types, and develop a better solution. Thanks for the suggestion @eduard13 and @DmitryFurs!
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
|
Apologies, got occupied with other work. Will try to work on this over this weekend. |
|
Hello, @drpayyne! Could you please change the base branch to the 4.3.0-develop? Regards, |
|
Hello, @drpayyne! Any updates here? Regards, |
|
Hi @bohdan-harniuk, unfortunately I'm held up with work and won't be able to get this PR to completion as it's been quite a while too. If anyone can continue this PR, that'd be great. Thank you! |
|
Hello, @doninAtwix! Please, take a look at this PR. Regards, |
|
Hello, @drpayyne! Thank you for your work here! Regards, |
Description (*)
Added support for images in copy magento path action.
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)